feat(daemon): Phase D — GEM300 in-the-loop (jobs, recipes, EC changes)

Semantics settled and documented: v1 is observe-and-report. The engine keeps
acking S16/S3/S7/S2F15 from its FSM tables — exactly the behaviour both
reference implementations validated — while the tool observes lifecycle
events on the Subscribe stream and reports physical progress back. Gating
stays the documented v2 deferred-reply item.

Engine: two new store observers (HandlerSlot pattern) — RecipeStore fires
(ppid, body) after an add (S7F3 downloads), EquipmentConstantStore fires
(id, value) on ACCEPTED S2F15 writes only. Unit-tested.

Daemon: the service registers PJ/recipe/EC observers (io thread; add_
observers coexist with register_default_handlers' primaries) and fans the
new HostRequest variants out via push_request (fire-and-forget, no-
buffering contract). ProcessJob carries action (Start->START, Resume->
RESUME, Paused->PAUSE, Stopping->STOP, Aborting->ABORT) + recipe + material
bindings read store-side on the io thread. ReportProcessJob maps SETTING_UP
->SetupComplete, COMPLETE->ProcessComplete, ABORTED->AbortComplete via
read_sync; PROCESSING is informational; unknown job => INVALID_OBJECT,
table-rejected transition => CANNOT_DO_NOW. Carriers deferred (CarrierStore
has no observer machinery; ReportCarrier stays UNIMPLEMENTED) — roadmap.

Python client: on_process_job / on_recipe / on_constant_change decorators +
report_job(job_id, state); ProcessJob dataclass exported.

Tests: daemon suite 141 -> 175 assertions — the full in-process loop
(S16F11 create -> tool setup -> S16F5 PJSTART -> stream ProcessJob with
recipe+carriers -> ReportProcessJob(COMPLETE) -> FSM at ProcessComplete),
rejection paths, S7F3 -> ProcessProgram, S2F15 -> ConstantChange with the
configured name. Core 475/3097 (observer units). Live regression: daemon
interop 20 checks + pyclient 13 checks still green against the running
daemon.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
2026-06-10 23:53:45 +02:00
parent b30443089f
commit b1772cfefd
10 changed files with 333 additions and 10 deletions
+2 -2
View File
@@ -6,7 +6,7 @@ stream/function, a format code, or a numeric id — just the names from your
equipment.yaml. equipment.yaml.
""" """
from ._client import Command, Equipment, Health, SecsGemError from ._client import Command, Equipment, Health, ProcessJob, SecsGemError
__all__ = ["Equipment", "Command", "Health", "SecsGemError"] __all__ = ["Equipment", "Command", "Health", "ProcessJob", "SecsGemError"]
__version__ = "0.1.0" __version__ = "0.1.0"
+53 -1
View File
@@ -63,6 +63,17 @@ class Command:
self._done = True self._done = True
@dataclass
class ProcessJob:
"""An E40 process job the host wants run (or stopped/aborted). Do the
physical work, then report progress with Equipment.report_job()."""
id: str
action: str # "START" | "STOP" | "PAUSE" | "RESUME" | "ABORT"
recipe: str
carriers: list
@dataclass @dataclass
class Health: class Health:
link: str # "DISCONNECTED" | "CONNECTED" | "SELECTED" link: str # "DISCONNECTED" | "CONNECTED" | "SELECTED"
@@ -79,6 +90,9 @@ class Equipment:
grpc.channel_ready_future(self._channel).result(timeout=connect_timeout) grpc.channel_ready_future(self._channel).result(timeout=connect_timeout)
self._stub = rpc.EquipmentStub(self._channel) self._stub = rpc.EquipmentStub(self._channel)
self._handlers: Dict[str, Callable[[Command], object]] = {} self._handlers: Dict[str, Callable[[Command], object]] = {}
self._job_handler: Optional[Callable[[ProcessJob], object]] = None
self._recipe_handler: Optional[Callable[[str, bytes], object]] = None
self._constant_handler: Optional[Callable[[str, object], object]] = None
self._listen_thread: Optional[threading.Thread] = None self._listen_thread: Optional[threading.Thread] = None
self._stop = threading.Event() self._stop = threading.Event()
@@ -167,6 +181,30 @@ class Equipment:
return register return register
def on_process_job(self, fn: Callable[[ProcessJob], object]):
"""Decorator: the host wants a process job run/stopped (E40).
Report progress with report_job()."""
self._job_handler = fn
return fn
def on_recipe(self, fn: Callable[[str, bytes], object]):
"""Decorator: the host downloaded a recipe (ppid, body)."""
self._recipe_handler = fn
return fn
def on_constant_change(self, fn: Callable[[str, object], object]):
"""Decorator: the host changed an equipment constant (name, value)."""
self._constant_handler = fn
return fn
def report_job(self, job_id: str, state: str) -> None:
"""Report physical job progress: "SETTING_UP" | "PROCESSING" |
"COMPLETE" | "ABORTED". The daemon drives the E40 state machine and
notifies the host (S16F9)."""
req = pb.ProcessJobState(
job_id=job_id, state=pb.ProcessJobState.State.Value(state))
_check(self._stub.ReportProcessJob(req))
def listen(self, background: bool = False) -> None: def listen(self, background: bool = False) -> None:
"""Consume host requests and dispatch them to @eq.on handlers. """Consume host requests and dispatch them to @eq.on handlers.
Blocks; pass background=True to run on a daemon thread instead.""" Blocks; pass background=True to run on a daemon thread instead."""
@@ -188,8 +226,22 @@ class Equipment:
for hr in self._stub.Subscribe(pb.SubscribeRequest(client="secsgem_client")): for hr in self._stub.Subscribe(pb.SubscribeRequest(client="secsgem_client")):
if self._stop.is_set(): if self._stop.is_set():
return return
if hr.HasField("process_job") and self._job_handler:
j = hr.process_job
self._job_handler(ProcessJob(
j.job_id, pb.ProcessJob.Action.Name(j.action),
j.recipe, list(j.carriers)))
continue
if hr.HasField("process_program") and self._recipe_handler:
self._recipe_handler(hr.process_program.ppid,
hr.process_program.body)
continue
if hr.HasField("constant") and self._constant_handler:
self._constant_handler(hr.constant.name,
from_value(hr.constant.value))
continue
if not hr.HasField("command"): if not hr.HasField("command"):
continue # future HostRequest variants (jobs, carriers, ...) continue # carriers etc.: future variants
cmd = hr.command cmd = hr.command
handler = self._handlers.get(cmd.name) or self._handlers.get("*") handler = self._handlers.get(cmd.name) or self._handlers.get("*")
command = Command(cmd.id, cmd.name, command = Command(cmd.id, cmd.name,
+23 -6
View File
@@ -202,12 +202,29 @@ debts tax every later phase, and the most valuable tests aren't automated.
`cpp_mini_tool` is the worked example. `cpp_mini_tool` is the worked example.
### Phase D — GEM300 in-the-loop (process/carrier tools) ### Phase D — GEM300 in-the-loop (process/carrier tools)
10. Settle job/carrier semantics (who acks S16F5/S3F17, gate vs observe — 10. 🚧 Semantics SETTLED: v1 is **observe-and-report** — the engine keeps
see proto comments), then wire `ProcessJob`/`CarrierAction` onto the acking S16/S3/S7/S2F15 from its FSM tables (what both references
stream + `ReportProcessJob`/`ReportCarrier` into the PJ/CJ/carrier stores. validated); the tool observes lifecycle events on the stream and reports
11. ⬜ Recipe download (`ProcessProgram` on the stream when S7F3 lands) and physical progress back. Gating (tool decides the ack) = the documented
EC-change notification (`ConstantChange` when S2F15 lands). v2 deferred-reply item. ✅ `ProcessJob` on the stream (PJ store observer:
12. ⬜ Interop scenarios for jobs/carriers vs secsgem-py + secs4j. →Processing/Start=START, /Resume=RESUME, →Paused=PAUSE, →Stopping=STOP,
→Aborting=ABORT; carries recipe + material bindings) +
`ReportProcessJob` (SETTING_UP→SetupComplete, COMPLETE→ProcessComplete,
ABORTED→AbortComplete; PROCESSING informational; INVALID_OBJECT /
CANNOT_DO_NOW on unknown job / illegal transition). ⬜ Carriers deferred:
`CarrierStore` has no observer machinery yet — apply the HandlerSlot
pattern, then mirror the job wiring; `ReportCarrier` stays gRPC
UNIMPLEMENTED (the stub default) until then.
11. ✅ `ProcessProgram` on the stream when S7F3 lands (new RecipeStore
added-observer) and `ConstantChange` when S2F15 is ACCEPTED (new
EquipmentConstantStore changed-observer; rejected writes never fire).
Python client: `on_process_job`/`on_recipe`/`on_constant_change` +
`report_job`.
12. 🚧 In-process E2E covers the full job loop (S16F11→S16F5→stream→report→
FSM, 175-assertion daemon suite); secs4j's 55 checks run against the
daemon (declarative path). ⬜ A live host-driven job loop with a
subscribed tool needs raw S16 frames host-side (secsgem-py 0.3.0 lacks
S16 builders — see interop/raw_gem300_harness.py for the frame source).
### Phase E — hardening & operations ### Phase E — hardening & operations
13. ⬜ gRPC exposure: default to localhost + document UDS; optional TLS creds. 13. ⬜ gRPC exposure: default to localhost + document UDS; optional TLS creds.
@@ -189,6 +189,54 @@ class EquipmentService final : public pb::Equipment::Service {
bump_health(); bump_health();
}); });
for (const auto& ec : rt.model().ecids.all())
ecnames_.insert({ec.id, ec.name});
// GEM300 in-the-loop (Phase D, observe-and-report): forward job
// lifecycle, recipe downloads, and accepted EC writes onto the
// Subscribe stream. Observers fire on the io thread; push_request only
// takes the subscriber mutex briefly. add_ observers coexist with the
// primary handlers register_default_handlers installs (HandlerSlot).
rt.model().process_jobs.add_state_change_handler(
[this](const std::string& prjobid, gem::ProcessJobState,
gem::ProcessJobState to, gem::ProcessJobEvent trig) {
pb::ProcessJob::Action action;
using PS = gem::ProcessJobState;
using PE = gem::ProcessJobEvent;
if (to == PS::Processing && trig == PE::Start) action = pb::ProcessJob::START;
else if (to == PS::Processing && trig == PE::Resume) action = pb::ProcessJob::RESUME;
else if (to == PS::Paused) action = pb::ProcessJob::PAUSE;
else if (to == PS::Stopping) action = pb::ProcessJob::STOP;
else if (to == PS::Aborting) action = pb::ProcessJob::ABORT;
else return; // SettingUp/complete/etc.: not tool work
pb::HostRequest hr;
auto* job = hr.mutable_process_job();
job->set_job_id(prjobid);
job->set_action(action);
// Observer runs on the io thread — reading the store is safe.
if (const auto* pj = rt_.model().process_jobs.get(prjobid)) {
job->set_recipe(pj->ppid);
for (const auto& m : pj->mtrloutspec) job->add_carriers(m);
}
push_request(std::move(hr));
});
rt.model().recipes.add_added_handler(
[this](const std::string& ppid, const std::string& body) {
pb::HostRequest hr;
hr.mutable_process_program()->set_ppid(ppid);
hr.mutable_process_program()->set_body(body);
push_request(std::move(hr));
});
rt.model().ecids.add_changed_handler(
[this](uint32_t ecid, const s2::Item& value) {
pb::HostRequest hr;
auto it = ecnames_.find(ecid);
hr.mutable_constant()->set_name(
it != ecnames_.end() ? it->second : std::to_string(ecid));
*hr.mutable_constant()->mutable_value() = from_item(value);
push_request(std::move(hr));
});
// Host commands -> the Subscribe stream (the HCACK-4 contract). For every // Host commands -> the Subscribe stream (the HCACK-4 contract). For every
// YAML-declared command, install a behaviour handler that pushes the // YAML-declared command, install a behaviour handler that pushes the
// command to subscribed tool clients and answers the host immediately // command to subscribed tool clients and answers the host immediately
@@ -367,6 +415,43 @@ class EquipmentService final : public pb::Equipment::Service {
return grpc::Status::OK; return grpc::Status::OK;
} }
// E40 progress reports (Phase D, observe-and-report): the tool advances
// the physical work and tells the engine; the engine drives the FSM and
// emits the matching S16F9 alert / CEIDs to the host. PROCESSING is
// informational (the engine entered it when the host commanded Start).
grpc::Status ReportProcessJob(grpc::ServerContext*, const pb::ProcessJobState* req,
pb::Ack* resp) override {
const std::string job_id = req->job_id();
const auto state = req->state();
auto outcome = rt_.read_sync([this, job_id, state]() -> std::optional<bool> {
auto& pjs = rt_.model().process_jobs;
if (!pjs.has(job_id)) return std::nullopt;
switch (state) {
case pb::ProcessJobState::SETTING_UP:
return pjs.fire_internal(job_id, gem::ProcessJobEvent::SetupComplete);
case pb::ProcessJobState::COMPLETE:
return pjs.fire_internal(job_id, gem::ProcessJobEvent::ProcessComplete);
case pb::ProcessJobState::ABORTED:
return pjs.fire_internal(job_id, gem::ProcessJobEvent::AbortComplete);
default:
return true; // PROCESSING: informational
}
});
if (!outcome) {
resp->set_code(pb::Ack::CANNOT_DO_NOW);
resp->set_message("engine io thread did not answer (not running?)");
} else if (!*outcome) {
resp->set_code(pb::Ack::INVALID_OBJECT);
resp->set_message("no process job '" + job_id + "'");
} else if (!**outcome) {
resp->set_code(pb::Ack::CANNOT_DO_NOW);
resp->set_message("E40 table rejects that transition from the current state");
} else {
resp->set_code(pb::Ack::ACCEPT);
}
return grpc::Status::OK;
}
// Operator-panel control-state transitions (e.g. "offline for maintenance"). // Operator-panel control-state transitions (e.g. "offline for maintenance").
// Fires the operator events on the io thread and reports what the E30 table // Fires the operator events on the io thread and reports what the E30 table
// actually did: ACCEPT iff the equipment landed in the requested state, // actually did: ACCEPT iff the equipment landed in the requested state,
@@ -448,6 +533,15 @@ class EquipmentService final : public pb::Equipment::Service {
} }
private: private:
// Fan a HostRequest out to every subscriber (fire-and-forget
// notifications: jobs, recipes, EC changes). No subscriber = dropped,
// matching the no-buffering contract.
void push_request(pb::HostRequest hr) {
std::lock_guard<std::mutex> lk(subs_mu_);
for (auto& sub : subs_) sub->queue.push_back(hr);
if (!subs_.empty()) subs_cv_.notify_all();
}
// The command-forwarding handler (runs on the io thread during S2F41/F21/ // The command-forwarding handler (runs on the io thread during S2F41/F21/
// F49 dispatch). Subscriber present -> queue the command + HCACK 4; absent // F49 dispatch). Subscriber present -> queue the command + HCACK 4; absent
// -> the command's declarative YAML ack. Never blocks. // -> the command's declarative YAML ack. Never blocks.
@@ -514,6 +608,7 @@ class EquipmentService final : public pb::Equipment::Service {
std::map<std::string, VarRef> vars_; // SVIDs + DVIDs (SVIDs win on clash) std::map<std::string, VarRef> vars_; // SVIDs + DVIDs (SVIDs win on clash)
std::map<std::string, uint32_t> events_; // CEID by name std::map<std::string, uint32_t> events_; // CEID by name
std::map<std::string, uint32_t> alarms_; // ALID by name AND stringified id std::map<std::string, uint32_t> alarms_; // ALID by name AND stringified id
std::map<uint32_t, std::string> ecnames_; // ECID -> name (ConstantChange)
// WatchHealth plumbing: observers (io thread) bump the version and wake the // WatchHealth plumbing: observers (io thread) bump the version and wake the
// per-stream wait loops (gRPC threads). // per-stream wait loops (gRPC threads).
@@ -1,6 +1,7 @@
#pragma once #pragma once
#include <cstdint> #include <cstdint>
#include <functional>
#include <map> #include <map>
#include <optional> #include <optional>
#include <stdexcept> #include <stdexcept>
@@ -9,6 +10,7 @@
#include <variant> #include <variant>
#include <vector> #include <vector>
#include "secsgem/gem/handler_slot.hpp"
#include "secsgem/secs2/item.hpp" #include "secsgem/secs2/item.hpp"
namespace secsgem::gem { namespace secsgem::gem {
@@ -59,10 +61,18 @@ class EquipmentConstantStore {
if (it == by_id_.end()) return EquipmentAck::Denied_UnknownEcid; if (it == by_id_.end()) return EquipmentAck::Denied_UnknownEcid;
if (!in_range(it->second, value)) return EquipmentAck::Denied_OutOfRange; if (!in_range(it->second, value)) return EquipmentAck::Denied_OutOfRange;
it->second.value = std::move(value); it->second.value = std::move(value);
if (on_changed_) on_changed_(id, it->second.value);
return EquipmentAck::Accept; return EquipmentAck::Accept;
} }
// Observe ACCEPTED host writes (S2F15): fires after the value is stored.
// The tool reacts to process-parameter tuning; rejected writes don't fire.
using ChangedHandler = std::function<void(uint32_t, const s2::Item&)>;
void add_changed_handler(ChangedHandler h) { on_changed_.add(std::move(h)); }
private: private:
HandlerSlot<uint32_t, const s2::Item&> on_changed_;
// For numeric formats, parse min_str / max_str as integers / doubles and // For numeric formats, parse min_str / max_str as integers / doubles and
// compare against the first value of the array (we don't support setting // compare against the first value of the array (we don't support setting
// multi-element ECs in this implementation). // multi-element ECs in this implementation).
+11 -1
View File
@@ -1,12 +1,14 @@
#pragma once #pragma once
#include <cstdint> #include <cstdint>
#include <functional>
#include <map> #include <map>
#include <optional> #include <optional>
#include <string> #include <string>
#include <utility> #include <utility>
#include <vector> #include <vector>
#include "secsgem/gem/handler_slot.hpp"
#include "secsgem/secs2/item.hpp" #include "secsgem/secs2/item.hpp"
namespace secsgem::gem { namespace secsgem::gem {
@@ -45,8 +47,15 @@ struct FormattedRecipe {
class RecipeStore { class RecipeStore {
public: public:
// Observe recipe arrivals (e.g. a host S7F3 download): fires after the
// store is updated, with (ppid, body). Multi-observer via HandlerSlot —
// the gRPC daemon forwards these onto its Subscribe stream.
using AddedHandler = std::function<void(const std::string&, const std::string&)>;
void add_added_handler(AddedHandler h) { on_added_.add(std::move(h)); }
void add(std::string ppid, std::string body) { void add(std::string ppid, std::string body) {
by_ppid_.insert_or_assign(std::move(ppid), std::move(body)); auto it = by_ppid_.insert_or_assign(std::move(ppid), std::move(body)).first;
if (on_added_) on_added_(it->first, it->second);
} }
std::optional<std::string> get(const std::string& ppid) const { std::optional<std::string> get(const std::string& ppid) const {
auto it = by_ppid_.find(ppid); auto it = by_ppid_.find(ppid);
@@ -95,6 +104,7 @@ class RecipeStore {
private: private:
std::map<std::string, std::string> by_ppid_; std::map<std::string, std::string> by_ppid_;
HandlerSlot<const std::string&, const std::string&> on_added_;
std::map<std::string, FormattedRecipe> formatted_; std::map<std::string, FormattedRecipe> formatted_;
}; };
+107
View File
@@ -380,3 +380,110 @@ TEST_CASE("Subscribe: S2F41 -> stream -> HCACK 4; declarative fallback without s
server->Shutdown(); server->Shutdown();
rt.stop(); rt.stop();
} }
// Phase D — GEM300 in-the-loop (observe-and-report): job lifecycle, recipe
// downloads, and EC writes flow host -> engine -> Subscribe stream; the tool
// reports physical progress back and the engine drives the E40 FSM.
TEST_CASE("Phase D: jobs, recipes, and EC changes on the stream; ReportProcessJob") {
gem::EquipmentRuntime rt(test_config());
gem::register_default_handlers(rt);
dmn::EquipmentService svc(rt);
rt.run_async();
grpc::ServerBuilder builder;
builder.RegisterService(&svc);
std::unique_ptr<grpc::Server> server(builder.BuildAndStart());
REQUIRE(server);
auto stub = pb::Equipment::NewStub(server->InProcessChannel(grpc::ChannelArguments{}));
grpc::ClientContext sub_ctx;
pb::SubscribeRequest sreq;
auto reader = stub->Subscribe(&sub_ctx, sreq);
std::this_thread::sleep_for(std::chrono::milliseconds(100)); // registration
auto dispatch = [&](s2::Message msg) {
auto reply = rt.read_sync([&rt, &msg]() { return rt.router().dispatch(msg); });
REQUIRE(reply.has_value());
REQUIRE(reply->has_value());
};
// Host creates the PJ (S16F11), the tool sets up, the host starts it.
gem::PRJobCreateRequest pj{"PJ-D-1", gem::MaterialFlag::Substrate,
gem::ProcessRecipeMethod::RecipeOnly,
gem::RecipeSpec{"RECIPE-A", {}}, {"WFR-D-1"}, {}};
dispatch(gem::s16f11_pr_job_create(pj));
auto setup = rt.read_sync([&rt]() {
rt.model().process_jobs.fire_internal("PJ-D-1", gem::ProcessJobEvent::Select);
return rt.model().process_jobs.fire_internal("PJ-D-1",
gem::ProcessJobEvent::SetupComplete);
});
REQUIRE(setup.has_value());
REQUIRE(*setup);
dispatch(gem::s16f5_pr_job_command("PJ-D-1", "PJSTART"));
// The tool's stream receives the job with recipe + material bindings.
pb::HostRequest hr;
REQUIRE(reader->Read(&hr));
REQUIRE(hr.has_process_job());
CHECK(hr.process_job().job_id() == "PJ-D-1");
CHECK(hr.process_job().action() == pb::ProcessJob::START);
CHECK(hr.process_job().recipe() == "RECIPE-A");
REQUIRE(hr.process_job().carriers_size() == 1);
CHECK(hr.process_job().carriers(0) == "WFR-D-1");
// The tool finishes the physical work and reports; the engine's FSM follows.
{
grpc::ClientContext ctx;
pb::ProcessJobState rep;
pb::Ack ack;
rep.set_job_id("PJ-D-1");
rep.set_state(pb::ProcessJobState::COMPLETE);
REQUIRE(stub->ReportProcessJob(&ctx, rep, &ack).ok());
CHECK(ack.code() == pb::Ack::ACCEPT);
}
auto state = rt.read_sync(
[&rt]() { return rt.model().process_jobs.state("PJ-D-1"); });
REQUIRE(state.has_value());
CHECK(*state == gem::ProcessJobState::ProcessComplete);
// Reporting against an unknown job / an illegal transition is rejected.
{
grpc::ClientContext ctx;
pb::ProcessJobState rep;
pb::Ack ack;
rep.set_job_id("PJ-GHOST");
rep.set_state(pb::ProcessJobState::COMPLETE);
REQUIRE(stub->ReportProcessJob(&ctx, rep, &ack).ok());
CHECK(ack.code() == pb::Ack::INVALID_OBJECT);
}
{
grpc::ClientContext ctx;
pb::ProcessJobState rep;
pb::Ack ack;
rep.set_job_id("PJ-D-1"); // already ProcessComplete
rep.set_state(pb::ProcessJobState::COMPLETE);
REQUIRE(stub->ReportProcessJob(&ctx, rep, &ack).ok());
CHECK(ack.code() == pb::Ack::CANNOT_DO_NOW);
}
// Host downloads a recipe (S7F3) -> ProcessProgram on the stream.
dispatch(gem::s7f3_process_program_send("RECIPE-NEW", "step1\nstep2\n"));
REQUIRE(reader->Read(&hr));
REQUIRE(hr.has_process_program());
CHECK(hr.process_program().ppid() == "RECIPE-NEW");
CHECK(hr.process_program().body() == "step1\nstep2\n");
// Host writes an EC (S2F15) -> ConstantChange with the configured name.
dispatch(gem::s2f15_ec_send({{10, s2::Item::u4(uint32_t{1})}}));
REQUIRE(reader->Read(&hr));
REQUIRE(hr.has_constant());
CHECK(hr.constant().name() == "TimeFormat");
CHECK(hr.constant().value().integer() == 1);
sub_ctx.TryCancel();
pb::HostRequest drain;
while (reader->Read(&drain)) {}
(void)reader->Finish();
server->Shutdown();
rt.stop();
}
+32
View File
@@ -444,3 +444,35 @@ TEST_CASE("spool persistence: clear deletes files") {
fs::remove_all(dir); fs::remove_all(dir);
} }
TEST_CASE("RecipeStore added-observer fires after the store is updated") {
RecipeStore r;
std::string seen_ppid, seen_body;
r.add_added_handler([&](const std::string& p, const std::string& b) {
seen_ppid = p;
seen_body = b;
});
r.add("R-1", "body");
CHECK(seen_ppid == "R-1");
CHECK(seen_body == "body");
CHECK(r.get("R-1").has_value()); // observer saw the post-update store
}
TEST_CASE("EquipmentConstantStore changed-observer fires on Accept only") {
EquipmentConstantStore ecids;
ecids.add({10, "Knob", "", s2::Item::u4(uint32_t{1}),
s2::Item::u4(uint32_t{1}), "0", "5"});
int fired = 0;
ecids.add_changed_handler([&](uint32_t id, const s2::Item& v) {
++fired;
CHECK(id == 10);
CHECK(v == s2::Item::u4(uint32_t{3}));
});
CHECK(ecids.set_value(10, s2::Item::u4(uint32_t{3})) == EquipmentAck::Accept);
CHECK(fired == 1);
CHECK(ecids.set_value(10, s2::Item::u4(uint32_t{99})) ==
EquipmentAck::Denied_OutOfRange);
CHECK(ecids.set_value(999, s2::Item::u4(uint32_t{1})) ==
EquipmentAck::Denied_UnknownEcid);
CHECK(fired == 1); // rejected writes never fire
}