chore(phase0): name validation, golden frames, daemon into library tree, TSan daemon lane
Item 8a — ConfigValidator warns on non-identifier variable/event/alarm/ command names ([A-Za-z_][A-Za-z0-9_]*): language bindings expose names as kwargs/attributes, so 'Chamber Pressure' would be unusable in the planned Python client. Warning not error — the wire doesn't care. Tested (4 warning sites + good-name negative). Item 4 tail — golden frames for S5F1 (Binary ALCD / U4 ALID / ASCII ALTX) and a composed S6F11 (the production-critical report shape), bytes hand- computed from E5 encoding rules: external pins on message composition. Item 7 — equipment_service.hpp moved to include/secsgem/daemon/ (apps/ include-path hack removed) and a TSan daemon lane added locally + in CI. tools/tsan.supp suppresses races whose accesses sit entirely inside the UNinstrumented system libgrpc/libgpr/libabsl (epoll wakeups, absl Mutex GraphCycles bookkeeping); our frames stay fully checked. The lane earned its keep on first run: it caught a REAL threading-contract violation — a daemon test reading model stores from the test thread while the io thread serviced posted writes — fixed to use read_sync, exactly per the documented contract. Now TSan-clean under halt_on_error=1 in the full production threading shape. Suites: core 470/3068, daemon Release+TSan 125/125 each. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,20 @@
|
||||
# ThreadSanitizer suppressions — third-party noise only.
|
||||
#
|
||||
# The system libgrpc/libprotobuf are NOT built with TSan instrumentation, so
|
||||
# TSan cannot observe their internal synchronization and reports false
|
||||
# positives entirely inside the library (e.g. Epoll1Poller::DoEpollWait's
|
||||
# event-engine wakeup path). Suppressing by library keeps every frame of OUR
|
||||
# code fully checked: a real race in secsgem/daemon code still has our frames
|
||||
# in the stack and is NOT suppressed by these rules.
|
||||
#
|
||||
# Do not add suppressions for secsgem code here. Fix the race instead.
|
||||
#
|
||||
# libabsl_*: gRPC's absl Mutex keeps deadlock-detection bookkeeping
|
||||
# (GraphCycles) whose synchronization TSan cannot see in the uninstrumented
|
||||
# system build — every report's racing accesses sit fully inside
|
||||
# libabsl_graphcycles_internal/libabsl_malloc_internal frames.
|
||||
race:libgrpc.so
|
||||
race:libgrpc++.so
|
||||
race:libgpr.so
|
||||
race:libabsl_
|
||||
called_from_lib:libgrpc.so
|
||||
Reference in New Issue
Block a user